Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump Mantid version #124

Merged
merged 1 commit into from
Jul 8, 2024
Merged

bump Mantid version #124

merged 1 commit into from
Jul 8, 2024

Conversation

jmborr
Copy link
Member

@jmborr jmborr commented Jul 8, 2024 •
edited
Loading

References

Description of the changes:

simple update the version of the Mantid dependency to the latest Productio release

Manual test for the reviewer

(instructions to set up the environment)

Start RefRed GUI

(refred-dev)> PYTHONPATH=$(pwd):$PYTHONPATH ./scripts/start_refred.py

Or run tests

(refred-dev)> pytest test/unit/RefRed/test_main.py

Check list for the reviewer

  • I have verified the proposed changes
  • Author included tests for the proposed changes
  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
    • new functions and classes detailed docstrings, parameters documented
  • All tests are passing
  • Documentation is up to date

Check list for the author

  • I have added tests for my changes
  • I have updated the documentation accordingly
  • I included a link to IBM EWM Story or Defect

@jmborr
bump Mantid version
740b781 
Signed-off-by: Jose Borreguero <[email protected]>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.53%. Comparing base (61ab03b) to head (740b781).

Additional details and impacted files 
@@            Coverage Diff             @@
##             next     #124      +/-   ##
==========================================
- Coverage   60.57%   60.53%   -0.05%     
==========================================
  Files         121      121              
  Lines       10136    10125      -11     
==========================================
- Hits         6140     6129      -11     
  Misses       3996     3996

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmborr jmborr merged commit 0b10776 into next Jul 8, 2024
3 checks passed
@jmborr jmborr deleted the updateMantid branch July 8, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmborr @codecov-commenter